Added test for get_indirect_is_a() and update to EMMO 1.0.0-beta5 #679
Conversation
ontopy/patch.py
Outdated
| [locstr('ChemicalElement', 'en')] | ||
| ['ChemicalElement'] | ||
| >>> emmo.Atom['altLabel'] = 'Element' | ||
| >>> emmo.Atom['altLabel'] = locstr('Atomo', 'it') | ||
| >>> emmo.Atom['altLabel'] | ||
| [locstr('ChemicalElement', 'en'), 'Element', locstr('Atomo', 'it')] | ||
| ['ChemicalElement', 'Element', 'Atomo'] | ||
| """ |
There was a problem hiding this comment.
Which version of owlready2 do you have? With recent versions of owlready2 the locstr is returned.
There was a problem hiding this comment.
I have Owlready2 v0.41.
ontopy/ontology.py
Outdated
| "http://emmo-repo.github.io/versions/1.0.0-beta4/emmo.ttl" | ||
| "http://emmo-repo.github.io/versions/1.0.0-beta5/emmo.ttl" |
There was a problem hiding this comment.
We should not do this, but keep the latest stable version as standard.
There was a problem hiding this comment.
Fine for me. Then we can just drop this PR and skip testing get_indirect_is_a()
ontopy/ontology.py
Outdated
| ) | ||
| elif base_iri == "emmo-inferred": | ||
| base_iri = ( | ||
| "https://emmo-repo.github.io/versions/1.0.0-beta4/" | ||
| "https://emmo-repo.github.io/versions/1.0.0-beta5/" |
There was a problem hiding this comment.
We should not do this, but keep the latest stable version as standard.
ontopy/ontology.py
Outdated
| "emmo-inferred.ttl" | ||
| ) | ||
| elif base_iri == "emmo-development": | ||
| base_iri = ( | ||
| "https://emmo-repo.github.io/versions/1.0.0-beta4/" | ||
| "https://emmo-repo.github.io/versions/1.0.0-beta5/" |
There was a problem hiding this comment.
This is good, then we use emmo-development in the test
tests/ontopy_tests/test_patch.py
Outdated
| def test_get_indirect_is_a(emmo: "Ontology") -> None: | ||
| assert any( |
There was a problem hiding this comment.
| def test_get_indirect_is_a(emmo: "Ontology") -> None: | |
| assert any( | |
| def test_get_indirect_is_a() -> None: | |
| from ontopy import get_ontology | |
| emmo = get_ontology('emmo-development').load() | |
| assert any( |
There was a problem hiding this comment.
I suggest updating only the default 'emmo-develeopment' to beta5 and keep the stable noes to beta4. Then we can use the development version for this updated test only.
For the other tests and code that you have changed I have created issue #680
where I have copied in your changes with updates to beta5 so that these are not lost once the upgrade to new stable version of EMMO is done.
Fine with me. The valuable part is in PR #678. This PR just tests it. Feel free to close it. |
# Description Update test_unit_dimension in emmocheck to EMMO 1.0.0-beta5. A test for this PR is added in PR #679. ## Type of change <!-- Put an `x` in the box that applies. --> - [x] Bug fix. - [ ] New feature. - [ ] Documentation update. - [ ] Test update. ## Checklist <!-- Put an `x` in the boxes that apply. You can also fill these out after creating the PR. --> This checklist can be used as a help for the reviewer. - [ ] Is the code easy to read and understand? - [ ] Are comments for humans to read, not computers to disregard? - [ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)? - [ ] Has the documentation been updated as necessary? - [ ] Does this close the issue? - [ ] Is the change limited to the issue? - [ ] Are errors handled for all outcomes? - [ ] Does the new feature provide new restrictions on dependencies, and if so is this documented? ## Comments <!-- Additional comments here, including clarifications on checklist if applicable. --> --------- Co-authored-by: Francesca L. Bleken <[email protected]>
|
Fixed in PR#678 |
Description
Added test for get_indirect_is_a() in PR #678.
This test is kept in a separate PR since it expects EMMO 1.0.0-beta5. The update to 1.0.0-beta5 implies some additional updates...
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments